Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the index ID and source ID in the warn logs #4187

Merged
merged 2 commits into from
Nov 22, 2023
Merged

Add the index ID and source ID in the warn logs #4187

merged 2 commits into from
Nov 22, 2023

Conversation

tuziben
Copy link
Collaborator

@tuziben tuziben commented Nov 22, 2023

Description

As mentioned here #4113. To enhance warn log info.

How was this PR tested?

Describe how you tested this PR.

2023-11-22T14:55:22.305Z  WARN quickwit_indexing::actors::doc_processor: index_id="gh-archive" source_id="_ingest-api-source" error=ValueError("created_at", "failed to parse datetime `2023-11-11 09:53:11.123456` using the following formats: `rfc3339`")

@CLAassistant
Copy link

CLAassistant commented Nov 22, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@tuziben tuziben merged commit 3589542 into main Nov 22, 2023
4 checks passed
@tuziben tuziben deleted the add_index_id branch November 22, 2023 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guilload guilload guilload approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tuziben @CLAassistant @guilload @fmassot